[fix][io] KCA: 'desanitize' topic name for the pulsar's ctx calls#19756
Merged
eolivelli merged 1 commit intoapache:masterfrom Mar 9, 2023
Merged
[fix][io] KCA: 'desanitize' topic name for the pulsar's ctx calls#19756eolivelli merged 1 commit intoapache:masterfrom
eolivelli merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19756 +/- ##
=============================================
+ Coverage 26.40% 62.02% +35.61%
- Complexity 6427 25758 +19331
=============================================
Files 1597 1848 +251
Lines 123682 135882 +12200
Branches 13511 14954 +1443
=============================================
+ Hits 32658 84279 +51621
+ Misses 86336 43810 -42526
- Partials 4688 7793 +3105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 9, 2023
…ache#19756) (cherry picked from commit d4930a3)
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Mar 10, 2023
…ache#19756) (cherry picked from commit d4930a3)
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Mar 10, 2023
…ache#19756) (cherry picked from commit d4930a3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some kafka connectors use topic name to e.g. create table names but pulsar's topic URI does not comply with requirements of the table names. This problems either handled by the connector or by KCA if sanitizeTopicName is set to true.
Some kafka connectors use pause/resume API, in that case sanitized name has to be converted back to original URI to pass to Pulsar's components.
Modifications
Provided a way to resolve original topic URI.
Added unit test.
Verifying this change
This change added unit test.
Does this pull request potentially affect one of the following parts:
NO
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dlg99#10